Many things need to be considered when we do a code review (My design review checklist).
Is the code logically correct?
Are we following best practices?
Are we considering security?
Did we run a code review? If you have a team or enterprise developer edition, the code review may be found in the Analyze menu.
Is the code maintainable?
Is our code unnecessarily complex? I always favor simplicity until forced to do otherwise.
Is the error handling effective?
Will our code perform? I tend to assume it will until proven otherwise.
Are our objects loosely coupled?
Did we follow our coding standards? idesign has a pretty good C# and WCF coding standard freely available on their website (right hand side). http://www.idesign.net/idesign/DesktopDefault.aspx?tabindex=0&tabid=1
No comments:
Post a Comment